关于LPC17xx固件库定时器的Bug

在这篇日志里我提到了LPC17xx定时器部分的固件库有Bug，具体为作为计数器模式的时候固件库工作不正常，检查代码后发现有几处错误，此问题已反馈给NXP。这几天收到了NXP的答复，他们承认了这个错误并已将这个问题反馈给了相关的工程师。在报告Bug的过程中，我也尝试着修复这个Bug。下面是往来邮件和附件，包括问题的重现和我修改后的代码。

From: Case Notification [mailto:noreply@salesforce.com]

Sent: 2011 Feb 12 1:18 PM

To: Eric Wang

Subject: Case # 00001236: Bugs in LPC17xx Firmware library has been assigned to you.

*** New Case Assignment Notification ***

Following Case has been assigned to you:

Company:

Contact:

Case Number: 00001236

Subject: Bugs in LPC17xx Firmware library

Description: Related product: Microcontrollers, Cortex-M3 (32-bit), LPC1700

There might be a bug in LPC17xx Firmware library that when timer works in counter mode, the firmware library doesn’t work as expected. Some register names in the firmware code might be wrong(i.e. CCR and CTCR), and parameter check in the header files is also a mistake since it totally ignored counter falling mode etc.

bug fixed and update is expected.

Click on the link to access the Case: https://eu1.salesforce.com/500D000000E4byl

Hi Wang,

We just got a case from you.Thanks for your question.

Can you give more detail about your question?

How did you get the lib? From our website?

Lib can not work as expected, what are you expected?Is there any demo code?

You mean ” Some register names in the firmware code might be wrong(i.e. CCR and CTCR), and parameter check in the header files is also a mistake since it totally ignored counter falling mode etc.” Could you point it clearly?

If you provide more info, we could fix it asap.

Best Regards,

Eric Wang 王 超

PAE, MCU

NXP Semiconductor

Hi Wang,

Thank you for reply.

The lib is download from http://ics.nxp.com/support/documents/microcontrollers/?scope=LPC17xx , marked “LPC17xx CMSIS-Compliant Standard Peripheral Firmware Driver Library (GNU, Keil, IAR) “.

The user’s manual(UM10360) mentioned that timers in lpc17xx could be used as counters, which I think that on every certain edge on the certain pin would increase the counter by 1.

I’ll attach my demo project and you should extract the full library into it before run. I tested it with LPC1768.

I tried to correct the mistake and it’s also attached, I modified these lines

File lpc17xx_timer.h, Line 142

File lpc17xx_timer.c, Line 320, 321, 344, 346

I have comments on these lines and they begin with”//!!”

I’m not sure if there are more mistakes and you should have a double check on it.

Regards,

王盛业

复旦大学复旦学院克卿书院 10607班

复旦大学信息科学与工程学院 电子信息科学类

Hi,

Thanks for your info. I have a look and find following should be mistake. I will forward to related engineer to fix.

File lpc17xx_timer.h, Line 142

File lpc17xx_timer.c, Line 320, 321, 344, 346

For counter function, I will check and give you feedback at convenience.

Best Regards,

Eric Wang 王 超

PAE, MCU

NXP Semiconductor

补充：后来又收到了NXP的邮件，算是总结性的答复。大致内容和上面的类似，然而可能我表达不清他以为我报告器件有Bug。学好英语很重要……

Dear Shengye,

Your inquiry is resolved for your case 00001236: Bugs in LPC17xx Firmware library

Solution answer:

Hi Shengye,

Thanks for your mail.

I check the lib which can downlaod from link http://ics.nxp.com/support/documents/microcontrollers/zip/lpc17xx.cmsis.driver.library.zip .

For line 142 in lpc17xx_timer.h, #define PARAM_TIM_MODE_OPT(MODE) ((MODE == TIM_TIMER_MODE)||(MODE == TIM_COUNTER_RISING_MODE)\

|| (MODE == TIM_COUNTER_RISING_MODE)||(MODE == TIM_COUNTER_RISING_MODE)) should be

#define PARAM_TIM_MODE_OPT(MODE) ((MODE == TIM_TIMER_MODE)||(MODE == TIM_COUNTER_RISING_MODE)\

|| (MODE == TIM_COUNTER_FALLING_MODE)||(MODE == TIM_COUNTER_ANY_MODE)) .

For line 320, 344, 346 in lpc17xx_timer.c, TIMx->CCR should be TIMx->CTCR .

line 321 should beTIMx->CTCR |= TimerCounterMode;

I will forward to related engineer check and fix.

Btw, you refer that Counter register can not be incremented after related edge. Pls confirm that he frequency of the CAP input can not exceed one quarter of the PCLK clock. If exceed, count will not identify the edge.

Please let us know if this does not resolve your inquiry. Your ticket will remain closed if we do not hear from you.

Registration in my.NXP (www.nxp.com/my) is required for you to check your question status and/or submit a follow-up to your question. For any reference to this question, use the following number:

* Case# 00001236.

*** TIPS ***

- Please do not reply to this email, it has been sent automatically.

- Modify your junk or spam setting to allow incoming “nxp.com” e-mail addresses.

- Add the sender, “NXP Technical Support” to your list of known contacts.

Best Regards,

The NXP Technical Support Team

NXP Semiconductors

学习LPC17xx – IIC

这是IIC操作EEPROM的例子。在调试过程中，误将从机地址写为0×01010000而导致出错，这是十六进制而非二进制！

• 千万别傻傻地把从机地址弄错，0×01010000这种错误不能犯！这是十六进制，不是二进制！

代码如下：

#include <lpc17xx.h>
#include <stdint.h>
#include "lpc17xx_libcfg.h"
#include <debug_frmwrk.h>
#include <lpc17xx_pinsel.h>
#include <lpc17xx_i2c.h>
 
uint32_t _DGETNUM(uint8_t cnt)
{
	uint32_t rtn = 0;
	while(cnt--) {
		rtn = rtn * 10 + (_DG - '0');
	}
	return rtn;
}
 
uint8_t buf[100];
 
uint32_t writeEEPROM(uint32_t len)
{
	I2C_M_SETUP_Type i2ccfg;
	i2ccfg.sl_addr7bit = 0x50;
	i2ccfg.tx_data = buf;
	i2ccfg.tx_length = len;
	i2ccfg.tx_count = 0;
	i2ccfg.rx_data = NULL;
	i2ccfg.rx_length = 0;
	i2ccfg.rx_count = 0;
	i2ccfg.retransmissions_max = 1;
	i2ccfg.retransmissions_count = 0;
	i2ccfg.status = 0;
   	i2ccfg.callback = NULL;
	return I2C_MasterTransferData(LPC_I2C0, &i2ccfg, I2C_TRANSFER_POLLING) == SUCCESS;
}
 
uint32_t readEEPROM(uint32_t len)
{
	I2C_M_SETUP_Type i2ccfg;
	i2ccfg.sl_addr7bit = 0x50;
	i2ccfg.tx_data = buf;
	i2ccfg.tx_length = 1;
	i2ccfg.tx_count = 0;
	i2ccfg.rx_data = buf + 1;
	i2ccfg.rx_length = len;
	i2ccfg.rx_count = 0;
	i2ccfg.retransmissions_max = 3;
	i2ccfg.retransmissions_count = 0;
	i2ccfg.status = 0;
   	i2ccfg.callback = NULL;
	return I2C_MasterTransferData(LPC_I2C0, &i2ccfg, I2C_TRANSFER_POLLING) == SUCCESS;
}
 
int main(void)
{
	char cmd;
	int i;
	uint8_t cnt, addr; 
	PINSEL_CFG_Type pincfg;
	debug_frmwrk_init();
	_DBG_("I2C EEPROM Test(W to write and R to read)");
 
	pincfg.Portnum = PINSEL_PORT_0;
	pincfg.Pinnum = PINSEL_PIN_27;
	pincfg.Funcnum = PINSEL_FUNC_1;
	pincfg.Pinmode = 0;
	pincfg.OpenDrain = 0;
	PINSEL_ConfigPin(&pincfg);
 
	pincfg.Portnum = PINSEL_PORT_0;
	pincfg.Pinnum = PINSEL_PIN_28;
	pincfg.Funcnum = PINSEL_FUNC_1;
	pincfg.Pinmode = 0;
	pincfg.OpenDrain = 0;
	PINSEL_ConfigPin(&pincfg);
 
	I2C_Init(LPC_I2C0, 100000);
	I2C_Cmd(LPC_I2C0, ENABLE);
	while(1) {
		_DBG_("Command(C), Length(2), Address(3)");
		cmd = _DG;
		cnt = _DGETNUM(2);
		addr = _DGETNUM(3);
		buf[0] = addr;
		switch(cmd) {
			case 'R':
				if (!readEEPROM(cnt)) _DBG_("Failed");
				for(i = 1; i <= cnt; ++ i) _DBC(buf[i]);
				_DBG_("");
				break;
			case 'W':
				i = 0;
				while(cnt --) {
					buf[++ i] = _DG;
					_DBG_("");
					if (i == 8 || cnt == 0) {
						if (!writeEEPROM(i + 1)){
							_DBG_("Failed");
							i = -1;
							break;
						} else {
							buf[0] += 8;
							i = 0;
						}
					}
				}
				if (i != -1) _DBG_("Successed");
				break;
		}
	}
}